Trait Items #72

Oliver · 2025-12-25T03:28:53Z

Oliver commented

2025-12-25 03:28:53 +00:00

This adds:

A more condensed Geist sheet
trait item type that can only be added geists

This adds: - A more condensed Geist sheet - `trait` item type that can only be added geists

Oliver added 29 commits 2025-12-25 03:28:54 +00:00

Remove parts of the item schemas that aren't necessary 507c9b0341

Get the foundation Trait type defined 8de63e91c7

Move dev-only hooks into their own folder that isn't included in the build 803c1673e2

Clean up some non-functional CSS 0e0f9d3831

Prevent creating a Trait when it's on a non-geist Actor 4d0f29d7f0

Add an item sheet for editing Traits 7de3f1ca87

Localize the button label d6beb4ba63

Remove unneeded helper method 165c24f32c

Implement the script that handles preparing the manifest for release e8baec0bc4

Add a custom mixin that allows doing complex structural position while maintaining partial rerenders ca185ba42a

Move the GenericApp mixin into the mixins folder 0626279fbe

Add dev button for getting an easy actor reference in the console 163423ea5b

Initialize the BookGeistSheet 7935a85188

Update the GenericApp to be using _prepareContext instead of _preparePartContext f237bce4d9

Update fate path preparation to use localized labels 28989c2d35

Update the GenericAppMixin so that it persists focus better 4a8ce9b099

Update the eslint indentation rule to be better when using a buncha mixins e7ac049ae3

Auto-equip weapons when embedded into Geist d81d86ef47

Add a helper to output a value if it's truthy or nothing otherwise 798e7441b4

Begin making the BookGeistSheet have the final design 28345bdef0

Add Craft as it's own section item. Display the attack range cd69228e68

Fix deprecation warning 0d1c2ddbb3

Remove log that's a bit spammy d70c5113b1

Finish the initial requirements for the header partial 8ed6f49c8d

Tweak the way armour shows up on the sheet so that it's a bit easier to deal with 1d13f38f81

Remove handlebars log f3aecc1ce8

Update the manifest to include an inDev property f1b23c54d8

Remove the devMode settings and use the inDev flag instead 8ea22d7eaf

Remove the menu option I have in the OFT module 5bee99a523

Oliver reviewed 2025-12-25 23:12:55 +00:00

module/Apps/ActorSheets/BookGeistSheet.mjs Outdated

					
				@ -0,0 +30,4 @@

						},

						form: {

							submitOnChange: true,

							closeOnSubmite: false,

Oliver commented

2025-12-25 22:41:46 +00:00

Remove e on key name

Remove `e` on key name

Oliver marked this conversation as resolved

module/Apps/ActorSheets/BookGeistSheet.mjs Outdated

					
				@ -0,0 +144,4 @@

								protection: 0,

								shielded: false,

							};

							if (armour) {

Oliver commented

2025-12-25 22:48:31 +00:00

This check is redundant

Oliver marked this conversation as resolved

module/handlebarHelpers/_index.mjs Outdated

					
				@ -9,5 +9,6 @@ export default {

					"rc-options": options,

					// #region Simple

					"rc-ifOut": (v) => (v || ``),

Oliver commented

2025-12-25 23:04:03 +00:00

This isn't used, get rid of it

Oliver marked this conversation as resolved

module/hooks/init.mjs Outdated

					
				@ -37,3 +38,4 @@

				import { registerSockets } from "../sockets/_index.mjs";

				import { registerUserSettings } from "../settings/userSettings.mjs";

				import { registerWorldSettings } from "../settings/worldSettings.mjs";

				import { TraitSheet } from "../Apps/ItemSheets/TraitSheet.mjs";

Oliver commented

2025-12-25 23:06:56 +00:00

Move to the correct import section

Oliver marked this conversation as resolved

module/hooks/init.mjs

					
				@ -103,3 +99,4 @@

						label: `RipCrypt.sheet-names.CraftCardV1`,

						themes: CraftCardV1.themes,

					});

					Actors.registerSheet(game.system.id, BookGeistSheet, {

Oliver commented

2025-12-25 23:07:49 +00:00

Add makeDefault

Add `makeDefault`

Oliver marked this conversation as resolved

templates/Apps/BookGeistSheet/header.hbs Outdated

					
				@ -0,0 +7,4 @@

						>

						<div class="grow"></div>

						<label for="{{meta-idp}}-rank">

							Rank

Oliver commented

2025-12-25 23:08:48 +00:00

Localize this

Oliver marked this conversation as resolved

templates/Apps/BookGeistSheet/items.hbs Outdated

					
				@ -0,0 +1,78 @@

				<div class="items">

					{{#if attacks}}

						<div>Attacks</div>

Oliver commented

2025-12-25 23:09:06 +00:00

Localize this

Oliver marked this conversation as resolved

templates/Apps/BookGeistSheet/items.hbs Outdated

					
				@ -0,0 +1,78 @@

				<div class="items">

					{{#if attacks}}

						<div>Attacks</div>

						<div>

Oliver commented

2025-12-25 23:09:33 +00:00

Convert this to a semantic list

Oliver marked this conversation as resolved

templates/Apps/BookGeistSheet/items.hbs Outdated

					
				@ -0,0 +20,4 @@

						</div>

					{{/if}}

					{{#if crafts}}

						<div>Craft</div>

Oliver commented

2025-12-25 23:09:15 +00:00

Localize this

Oliver marked this conversation as resolved

templates/Apps/BookGeistSheet/items.hbs Outdated

					
				@ -0,0 +21,4 @@

					{{/if}}

					{{#if crafts}}

						<div>Craft</div>

						<div>

Oliver commented

2025-12-25 23:09:44 +00:00

Convert this to a semantic list

Oliver marked this conversation as resolved

templates/Apps/BookGeistSheet/items.hbs Outdated

					
				@ -0,0 +33,4 @@

							{{/each}}

						</div>

					{{/if}}

					<div>Defense</div>

Oliver commented

2025-12-25 23:09:51 +00:00

Localize this

Oliver marked this conversation as resolved

templates/Apps/BookGeistSheet/items.hbs Outdated

					
				@ -0,0 +54,4 @@

							</li>

						{{/each}}

					</ul>

					<div>Traits</div>

Oliver commented

2025-12-25 23:10:05 +00:00

Localize this

Oliver marked this conversation as resolved

templates/Apps/BookGeistSheet/items.hbs Outdated

					
				@ -0,0 +72,4 @@

								{{/if}}

							</li>

						{{else}}

							None

Oliver commented

2025-12-25 23:10:13 +00:00

Localize this

Oliver marked this conversation as resolved

templates/Apps/BookGeistSheet/stats.hbs Outdated

					
				@ -0,0 +2,4 @@

					<table>

						<thead>

							<tr>

								<td class="alt">Path</td>

Oliver commented

2025-12-25 23:10:34 +00:00

Localize these headers

Oliver marked this conversation as resolved

Oliver added 7 commits 2025-12-25 23:37:35 +00:00

Oliver added 2 commits 2025-12-25 23:46:14 +00:00

Add a hook listener to prevent invasive tweaks from OFT during development 07cba3d409

Use semantic lists for the other item lists b5b022247e

Oliver added 1 commit 2025-12-25 23:46:37 +00:00

Merge branch 'main' into feature/trait-items 316c0645d1

Oliver added 1 commit 2025-12-25 23:56:51 +00:00

Update the verified version 180a050811

Oliver added 1 commit 2025-12-26 00:14:30 +00:00

Add the Forgejo URL for the main project repo 0d42db1457

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin feature/trait-items:feature/trait-items

git checkout feature/trait-items

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff feature/trait-items

git checkout feature/trait-items

git rebase main

git checkout main

git merge --ff-only feature/trait-items

git checkout feature/trait-items

git rebase main

git checkout main

git merge --no-ff feature/trait-items

git checkout main

git merge --squash feature/trait-items