PR feedback pt 1

This commit is contained in:
Oliver-Akins 2025-03-04 15:45:33 -07:00
parent ebed79e93d
commit 8896903008
7 changed files with 42 additions and 23 deletions

View file

@ -67,6 +67,7 @@
"hard": "Hard", "hard": "Hard",
"random": "Random Condition" "random": "Random Condition"
}, },
"difficulty": "Difficulty",
"drag": "Drag", "drag": "Drag",
"edit": "Edit", "edit": "Edit",
"edge": "Edge", "edge": "Edge",
@ -78,11 +79,23 @@
"guts": "Guts", "guts": "Guts",
"location": "Location", "location": "Location",
"move": "Move", "move": "Move",
"path": { "ordinals": {
"North": "North", "North": {
"East": "East", "full": "North",
"South": "South", "abbv": "N"
"West": "West" },
"East": {
"full": "East",
"abbv": "E"
},
"South": {
"full": "South",
"abbv": "S"
},
"West": {
"full": "West",
"abbv": "W"
}
}, },
"protection": "Protection", "protection": "Protection",
"quantity": "Quantity", "quantity": "Quantity",
@ -171,7 +184,11 @@
} }
}, },
"tooltips": { "tooltips": {
"shield-bonus": "Shield Bonus: {value}" "shield-bonus": "Shield Bonus: {value}",
"set-fate-to": "Set Fate to {ordinal}",
"current-tour": "Current Delve Tour",
"next-tour": "Next Delve Tour",
"prev-tour": "Previous Delve Tour"
} }
} }
} }

View file

@ -117,7 +117,7 @@ export class HeroSummaryCardV1 extends GenericAppMixin(HandlebarsApplicationMixi
ctx.fate.options = [ ctx.fate.options = [
{ label: `RipCrypt.common.empty`, v: `` }, { label: `RipCrypt.common.empty`, v: `` },
...Object.values(gameTerms.FatePath) ...Object.values(gameTerms.FatePath)
.map(v => ({ label: `RipCrypt.common.path.${v}`, value: v })), .map(v => ({ label: `RipCrypt.common.ordinals.${v}.full`, value: v })),
]; ];
return ctx; return ctx;
}; };

View file

@ -1,7 +1,7 @@
<div id="delve-difficulty"> <div id="delve-difficulty">
<div <div
class="icon-container" class="icon-container"
data-tooltip="Difficulty: 8" data-tooltip="RipCrypt.common.difficulty"
> >
<span class="large">{{dc}}</span> <span class="large">{{dc}}</span>
<rc-icon <rc-icon

View file

@ -15,10 +15,10 @@
style="grid-area: N;" style="grid-area: N;"
data-action="setFate" data-action="setFate"
data-to-fate="North" data-to-fate="North"
data-tooltip="Set Fate to North" data-tooltip="{{rc-i18n "RipCrypt.tooltips.set-fate-to" ordinal="@RipCrypt.common.ordinals.North.full"}}"
data-tooltip-direction="LEFT" data-tooltip-direction="LEFT"
> >
N {{rc-i18n "RipCrypt.common.ordinals.North.abbv"}}
</button> </button>
<button <button
type="button" type="button"
@ -26,10 +26,10 @@
style="grid-area: W;" style="grid-area: W;"
data-action="setFate" data-action="setFate"
data-to-fate="West" data-to-fate="West"
data-tooltip="Set Fate to West" data-tooltip="{{rc-i18n "RipCrypt.tooltips.set-fate-to" ordinal="@RipCrypt.common.ordinals.West.full"}}"
data-tooltip-direction="LEFT" data-tooltip-direction="LEFT"
> >
W {{rc-i18n "RipCrypt.common.ordinals.West.abbv"}}
</button> </button>
<button <button
type="button" type="button"
@ -37,10 +37,10 @@
style="grid-area: E;" style="grid-area: E;"
data-action="setFate" data-action="setFate"
data-to-fate="East" data-to-fate="East"
data-tooltip="Set Fate to East" data-tooltip="{{rc-i18n "RipCrypt.tooltips.set-fate-to" ordinal="@RipCrypt.common.ordinals.East.full"}}"
data-tooltip-direction="RIGHT" data-tooltip-direction="RIGHT"
> >
E {{rc-i18n "RipCrypt.common.ordinals.East.abbv"}}
</button> </button>
<button <button
type="button" type="button"
@ -48,16 +48,16 @@
style="grid-area: S;" style="grid-area: S;"
data-action="setFate" data-action="setFate"
data-to-fate="South" data-to-fate="South"
data-tooltip="Set Fate to South" data-tooltip="{{rc-i18n "RipCrypt.tooltips.set-fate-to" ordinal="@RipCrypt.common.ordinals.South.full"}}"
data-tooltip-direction="DOWN" data-tooltip-direction="DOWN"
> >
S {{rc-i18n "RipCrypt.common.ordinals.South.abbv"}}
</button> </button>
{{else}} {{else}}
<span style="grid-area: N;">N</span> <span style="grid-area: N;">{{rc-i18n "RipCrypt.common.ordinals.North.abbv"}}</span>
<span style="grid-area: W;">W</span> <span style="grid-area: W;">{{rc-i18n "RipCrypt.common.ordinals.West.abbv"}}</span>
<span style="grid-area: E;">E</span> <span style="grid-area: E;">{{rc-i18n "RipCrypt.common.ordinals.East.abbv"}}</span>
<span style="grid-area: S;">S</span> <span style="grid-area: S;">{{rc-i18n "RipCrypt.common.ordinals.South.abbv"}}</span>
{{/if}} {{/if}}
</div> </div>
</div> </div>

View file

@ -1,7 +1,7 @@
<div id="the-hourglass"> <div id="the-hourglass">
<div <div
class="icon-container" class="icon-container"
data-tooltip="Current Delve Tour" data-tooltip="RipCrypt.tooltips.current-tour"
> >
<span class="sands-value"> <span class="sands-value">
{{sandsOfFate}} {{sandsOfFate}}

View file

@ -8,7 +8,8 @@
class="icon" class="icon"
data-action="tourDelta" data-action="tourDelta"
data-delta="-1" data-delta="-1"
data-tooltip="Next Delve Tour" aria-label="{{rc-i18n "RipCrypt.tooltips.next-tour"}}"
data-tooltip="RipCrypt.tooltips.next-tour"
data-tooltip-direction="RIGHT" data-tooltip-direction="RIGHT"
> >
<rc-icon <rc-icon

View file

@ -8,7 +8,8 @@
class="icon" class="icon"
data-action="tourDelta" data-action="tourDelta"
data-delta="1" data-delta="1"
data-tooltip="Previous Delve Tour" aria-label="{{rc-i18n "RipCrypt.tooltips.prev-tour"}}"
data-tooltip="RipCrypt.tooltips.prev-tour"
data-tooltip-direction="LEFT" data-tooltip-direction="LEFT"
> >
<rc-icon <rc-icon