Foundry/oft
0
0
Fork 0
Code Issues 7 Pull requests Releases 3 Activity Actions

Move the tweak prevention into a helper function and rename the module hooks w/ compatibility code #26

Merged
Oliver merged 4 commits from feature/change-hook-name into main 2025-12-20 01:39:52 +00:00
Conversation 1 Commits 4 Files changed 20 +104 -102
Oliver commented 2025-12-19 05:33:27 +00:00
Owner
Copy link

Closes #25

Closes #25
Oliver added 1 commit 2025-12-19 05:33:27 +00:00
Oliver added 1 commit 2025-12-19 07:23:08 +00:00
Oliver added 1 commit 2025-12-19 07:24:06 +00:00
Oliver reviewed 2025-12-19 07:27:22 +00:00
module/utils/preRegisterTweak.mjs Outdated
@ -0,0 +11,4 @@
`The hook "${__ID__}.preventSetting" has been renamed "${__ID__}.registerTweak".`,
{ since: `v1.2.0`, until: `v2.0.0`, stack: false, once: true },
);
prevented &&= Hooks.call(`${__ID__}.preventSetting`);
Oliver commented 2025-12-19 07:27:19 +00:00
Author
Owner
Copy link

This needs to be updated because it won't call this hook if oft.preRegisterTweak is allowing the tweak to be registered

This needs to be updated because it won't call this hook if `oft.preRegisterTweak` is allowing the tweak to be registered
Oliver marked this conversation as resolved
Oliver added 1 commit 2025-12-20 01:39:02 +00:00
Oliver merged commit 97f8e293d2 into main 2025-12-20 01:39:52 +00:00
Oliver deleted branch feature/change-hook-name 2025-12-20 01:39:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat
Breaking
Breaking change that won't be backward compatible

  
Compat
Compatibility
A change that is 100% backwards-compatible

  
Compat
Deprecation
A change that is introducing a deprecation warning and a migration period

  
Foundry/v14

An issue affecting Foundry v14

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Non-Repro
Unable to reproduce the issue with the provided information

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat
Breaking
Compat
Compatibility
Compat
Deprecation
Foundry/v14
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Non-Repro
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Foundry/oft#26
No description provided.
Delete branch "feature/change-hook-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?