After opening an Attribute-Only Sheet, other sheets fail to render their content #47

New issue

Closed

opened 2026-03-16 04:28:54 +00:00 by Oliver · 0 comments

Oliver commented

2026-03-16 04:28:54 +00:00

Owner

Steps to Reproduce:

Have two actors, one set to an Attribute-Only sheet, the other set to either of the other two sheets
Open the non-attribute only actor's sheet, perceive the prose mirror editor
Open the Attribute-Only actor's sheet
Close the non-attribute only sheet
Reopen the non-attribute only sheet
Perceive the lack of the prose mirror editor

This is because when we do this:

static get PARTS() {
	const parts = super.PARTS;
	delete parts.tabs;
	delete parts.content;
	return parts;
};

we're editing the PARTS from the superclass as it is, to fix it we should just be deep-cloning the PARTS before mutating it

Steps to Reproduce: 1. Have two actors, one set to an Attribute-Only sheet, the other set to either of the other two sheets 2. Open the non-attribute only actor's sheet, perceive the prose mirror editor 3. Open the Attribute-Only actor's sheet 4. Close the non-attribute only sheet 5. Reopen the non-attribute only sheet 6. Perceive the lack of the prose mirror editor This is because when we do this: ```js static get PARTS() { const parts = super.PARTS; delete parts.tabs; delete parts.content; return parts; }; ``` we're editing the PARTS from the superclass as it is, to fix it we should just be deep-cloning the PARTS before mutating it