Foundry/taf
1
0
Fork 0
Code Issues 13 Pull requests Releases 9 Wiki Activity Actions

Prevent the attribute Items from getting invalid keys

Browse source
This commit is contained in:
Oliver 2026-04-25 13:55:01 -06:00
parent 3a7ffa4332
commit bda5d05969
4 changed files with 56 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

28
module/data/Item/attribute.mjs
View file

@ -1,3 +1,7 @@
import { isValidID, toID } from "../../utils/toID.mjs";
const { hasProperty } = foundry.utils;
export class AttributeItemData extends foundry.abstract.TypeDataModel {
// #region Schema
static defineSchema() {
@ -37,6 +41,17 @@ export class AttributeItemData extends foundry.abstract.TypeDataModel {
// #region Lifecycle
async _preCreate(data, options, user) {
// Assign the key as the ID'd name if isn't provided, or validate if
// it is provided.
if (!this.key) {
this.updateSource({ key: toID(this.parent.name) });
} else if (!isValidID(this.key)) {
ui.notifications.error(_loc(
`taf.notifs.error.invalid-attribute-key`,
{ key: this.key },
));
return false;
};
// Prevent duplicate Attribute keys from existing on a single Actor
if (this.parent.isEmbedded) {
@ -55,6 +70,19 @@ export class AttributeItemData extends foundry.abstract.TypeDataModel {
return super._preCreate(data, options, user);
};
async _preUpdate(data, options, user) {
// Prevent invalid IDs
if (hasProperty(data, `system.key`) && !isValidID(data.system.key)) {
ui.notifications.error(_loc(
`taf.notifs.error.invalid-attribute-key`,
{ key: data.system.key },
));
delete data.system?.key;
};
return super._preUpdate(data, options, user);
};
// #endregion Lifecycle
// #region Methods