Foundry/oft

Fork 0

`startSidebarExpanded` not working in v14 #42

New issue

Closed

opened 2026-01-31 00:49:27 +00:00 by Oliver · 1 comment

Oliver commented

2026-01-31 00:49:27 +00:00

Owner

In Foundry v14, the renderSidebar hook used for this setting is not being called at all. This may require changing the hook to be ready or some other render hook

In Foundry v14, the `renderSidebar` hook used for this setting is not being called at all. This may require changing the hook to be `ready` or some other render hook

Oliver added this to the v1.3.0 milestone 2026-01-31 00:49:27 +00:00

Oliver added the

labels 2026-01-31 00:49:27 +00:00

Oliver removed this from the v1.3.0 milestone 2026-01-31 00:49:49 +00:00

Oliver commented

2026-01-31 08:27:41 +00:00

Author

Owner

This seems to be caused because of the !game.ready check in the render hook.

Removing the not ready requirement does let the sidebar expand, however it takes quite a while before it happens. Which is caused by the scene transition duration, as it doesn't fire the render nor ready hook until the transition has finished completely.

If we can find a way to do this without requiring the render or ready hook, that would be best, but there's a chance that it won't be possible without a delay.

It might be worth checking if we can hook into _renderHTML or _insertHTML to mutate it prior to it hitting the DOM, but that would require almost a complete reimplementation of the expansion logic, which I don't want to do if I can avoid it

This seems to be caused because of the `!game.ready` check in the render hook. Removing the not ready requirement does let the sidebar expand, however it takes quite a while before it happens. Which is caused by the scene transition duration, as it doesn't fire the render nor ready hook until the transition has finished completely. If we can find a way to do this without requiring the render or ready hook, that would be best, but there's a chance that it won't be possible without a delay. --- It might be worth checking if we can hook into `_renderHTML` or `_insertHTML` to mutate it prior to it hitting the DOM, but that would require almost a complete reimplementation of the expansion logic, which I don't want to do if I can avoid it

Oliver added this to the v1.3.0 milestone 2026-02-01 07:11:31 +00:00

Oliver referenced this issue from a commit

2026-02-01 07:12:06 +00:00

Fix the sidebar starting position for v14 (closes #42)

Oliver closed this issue

2026-02-01 07:12:06 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Foundry/oft#42

No description provided.

Rows
Columns

startSidebarExpanded not working in v14 #42

`startSidebarExpanded` not working in v14 #42